Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(i): Convert old update tests to newer framework #2387

Merged
merged 3 commits into from
Mar 7, 2024
Merged

test(i): Convert old update tests to newer framework #2387

merged 3 commits into from
Mar 7, 2024

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #2386

Description

Converts old update tests to newer framework.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality labels Mar 7, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.10 milestone Mar 7, 2024
@AndrewSisley AndrewSisley self-assigned this Mar 7, 2024
@AndrewSisley AndrewSisley changed the title tests: Convert old update tests to newer framework test(i): Convert old update tests to newer framework Mar 7, 2024
@AndrewSisley AndrewSisley requested a review from a team March 7, 2024 01:03
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (b377876) to head (72a7f58).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2387      +/-   ##
===========================================
+ Coverage    75.12%   75.15%   +0.03%     
===========================================
  Files          268      268              
  Lines        25912    25912              
===========================================
+ Hits         19465    19473       +8     
+ Misses        5143     5137       -6     
+ Partials      1304     1302       -2
Flag Coverage Δ
all-tests 75.15% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b377876...72a7f58. Read the comment docs.

shahzadlone
shahzadlone approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, sooo close to all the old tests being migrated to the new setup.

Only have test.Request and test.Docs remaining now =)

@AndrewSisley AndrewSisley merged commit 4e9f6f4 into sourcenetwork:develop Mar 7, 2024
31 of 32 checks passed
@AndrewSisley AndrewSisley deleted the 2386-update-test-conv branch March 7, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.10
Development

Successfully merging this pull request may close these issues.

Convert old update tests to newer framework
2 participants
@AndrewSisley @shahzadlone